Skip to content

/ pagePiling.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the navigation property default value glitch. #161

Open
wants to merge 2 commits into
base: master
from
Open

Fixing the navigation property default value glitch. #161

wants to merge 2 commits into from

Conversation

@SakhirAtwi
Copy link
Contributor

SakhirAtwi commented Aug 7, 2018

Fixing Problem #160
@SakhirAtwi
Fixing the navigation property default value glitch.
7f6fb0d
@SakhirAtwi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SakhirAtwi commented Aug 7, 2018

@alvarotrigo I noticed that this fix is not yet complete, coz of the addVerticalNavigation() function later on in the code which will fire up anyways if the navigation object is not empty.
@SakhirAtwi
Fix the navigation property default value glitch (extended).
f73eeb9
@SakhirAtwi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SakhirAtwi commented Aug 7, 2018 •
edited

@alvarotrigo Alright all good, you can merge it peacefully now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@SakhirAtwi
You can’t perform that action at this time.