Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upGlitch in the navigation property of pagepiling function object. #160
Comments
This comment has been minimized.
This comment has been minimized.
|
@alvarotrigo I think its a serious issue to look into, but you seem to be not responding, IDK why. |
This comment has been minimized.
This comment has been minimized.
|
Busy with other things at the moment. I'll review it at some point in the future. |
This comment has been minimized.
This comment has been minimized.
|
@alvarotrigo alright, best ov luck :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@alvarotrigo The ReadMe file says that,
But if you make navigation property to true then nothing happens, as in the screen shot there is nothing in the right side of browser window,
The reason is by setting the value of property to true you are making it a boolean in the first place which is not what is supposed to happen. you should pass in a empty object for that to work.
Secondly, the property is not false by default either(As written in ReadMe) coz of the lines of code in plugin,
This is checking if object is empty which is not by default in the default configurations object passed to pagepiling function.
Fixes:
1)Either ReadMe can be changed that navigation is by default true(I mean taking in object), not "programmatically true", and you must false it to remove the navigation in the right.
2)Or I have created a pull request which will correct the plugin to use the empty object by defaut(Not creating the navigation) and will create the navigation bar as properties passed to it.
Side-Note:
navigation:trueis never going to work, coz it contradicts the type of property. Only empty object will be taken up, if taken up.