Skip to content

/ pagePiling.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollable Feature Not Working #41

Closed
McCarraDev opened this issue Mar 30, 2015 · 5 comments
Closed

Scrollable Feature Not Working #41

McCarraDev opened this issue Mar 30, 2015 · 5 comments
Labels
bug

Comments

@McCarraDev
Copy link

@McCarraDev McCarraDev commented Mar 30, 2015

I am using all of the updated js/css and am trying to use the scrollable feature by adding the "pp-scrollable" class to the section I want to us as so:

<div class="section pp-scrollable">

However it still continues to scroll past the whole section the second I start scrolling.

I even tried setting the height of the section to be a good amount bigger than the screen height and still nothing. Any idea why?

Thanks!
@alvarotrigo

This comment has been minimized.

Sign in to view
Copy link
Owner

@alvarotrigo alvarotrigo commented Mar 31, 2015

Are you using the latest version 1.5? Check it in case, because I updated it yesterday, just a few hours before you posted.
@alvarotrigo

This comment has been minimized.

Sign in to view
Copy link
Owner

@alvarotrigo alvarotrigo commented Mar 31, 2015

Right. I've just noticed a little bug while trying to reproduce your problem.
It is only working at the moment when using the option verticalCentered:false.

I'll fix it in a few minutes.
@alvarotrigo alvarotrigo added the bug label Mar 31, 2015
alvarotrigo added a commit that referenced this issue Mar 31, 2015
@alvarotrigo
- Fixed bug with `verticalCentered:true` and pp-scrollable #41
ea29b19 
- JSLint validation
@alvarotrigo

This comment has been minimized.

Sign in to view
Copy link
Owner

@alvarotrigo alvarotrigo commented Mar 31, 2015

Ok, solved in the last version 1.5.1
@McCarraDev

This comment has been minimized.

Sign in to view
Copy link
Author

@McCarraDev McCarraDev commented Mar 31, 2015

Thank you very much sir! Awesome plugin, thanks for developing it!
@fourroses666

This comment has been minimized.

Sign in to view
Copy link

@fourroses666 fourroses666 commented Sep 22, 2016

Was looking for this! Adding the "pp-scrollable" makes longer pages scrollable 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@McCarraDev @alvarotrigo @fourroses666
You can’t perform that action at this time.