Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scroll down when active section is last resolve #87 #89

Open
wants to merge 1 commit into
base: master
from

Conversation

@roofi07
Copy link

roofi07 commented Feb 15, 2016

No description provided.

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Feb 15, 2016

Can you add more information about what does if fixes, how to reproduce it or in which conditions it takes place?

@roofi07

This comment has been minimized.

Copy link
Author

roofi07 commented Feb 15, 2016

When you scroll down, method moveSectionDown checks whether the next section exists, if not, it does nothing and doing it over and over again. At the very end, when slow, delta equals the 0 and scrolls up.

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Feb 16, 2016

What browser and OS are you using to get a 0 value for delta?
Are you using a mouse or a trackpad?

I'm quite surprised you can get a zero value there. fullPage.js is using the same implementation to get the delta value and nobody complained about a similar issue.

I've tested this jsfiddle in Firefox, Chrome and IE and none of them return 0 to me when using a mouse wheel.

@roofi07

This comment has been minimized.

Copy link
Author

roofi07 commented Feb 16, 2016

I use osx and trackpad. When I tested this jsfiddle in Firefox it was good, but when I used Chrome at the end accelerate scroll console.log return -0.

fullPage.js work me too.

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Feb 16, 2016

fullPage.js work me too.

You mean, you don't get the error there?

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Feb 16, 2016

at the end accelerate scroll console.log return -0.

You mean, in the last section? Or accelerating after a normal scroll .

@roofi07

This comment has been minimized.

Copy link
Author

roofi07 commented Feb 16, 2016

You mean, you don't get the error there?

Yes, it's ok.

You mean, in the last section? Or accelerating after a normal scroll .

The osx scroll on the trackpad accelerates and slows down. The last point scroll the delta value is -0.

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Feb 16, 2016

Ok I'll take a look from home later.

@roofi07 roofi07 force-pushed the roofi07:master branch from 8b47d9b to 21bb9f9 Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.