Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed scroll down when active section is last resolve #87 #89
Conversation
This comment has been minimized.
This comment has been minimized.
Can you add more information about what does if fixes, how to reproduce it or in which conditions it takes place? |
This comment has been minimized.
This comment has been minimized.
When you scroll down, method moveSectionDown checks whether the next section exists, if not, it does nothing and doing it over and over again. At the very end, when slow, delta equals the 0 and scrolls up. |
This comment has been minimized.
This comment has been minimized.
What browser and OS are you using to get a 0 value for delta? I'm quite surprised you can get a zero value there. fullPage.js is using the same implementation to get the delta value and nobody complained about a similar issue. I've tested this jsfiddle in Firefox, Chrome and IE and none of them return 0 to me when using a mouse wheel. |
This comment has been minimized.
This comment has been minimized.
I use osx and trackpad. When I tested this jsfiddle in Firefox it was good, but when I used Chrome at the end accelerate scroll console.log return -0. fullPage.js work me too. |
This comment has been minimized.
This comment has been minimized.
You mean, you don't get the error there? |
This comment has been minimized.
This comment has been minimized.
You mean, in the last section? Or accelerating after a normal scroll . |
This comment has been minimized.
This comment has been minimized.
Yes, it's ok.
The osx scroll on the trackpad accelerates and slows down. The last point scroll the delta value is -0. |
This comment has been minimized.
This comment has been minimized.
Ok I'll take a look from home later. |
roofi07 commentedFeb 15, 2016
No description provided.