Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fullscren and video ratio when resize #7

Open
wants to merge 1 commit into
base: master
from

Conversation

@ppsirius
Copy link

ppsirius commented Oct 11, 2014

No description provided.

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Oct 12, 2014

Can you name the error? As it is working properly for me as it is.

@ppsirius

This comment has been minimized.

Copy link
Author

ppsirius commented Oct 12, 2014

The name of issue or what?

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Oct 12, 2014

Why do you think you had to fix the full screen video. I see it properly.

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Oct 12, 2014

Oh I see, there were some mistakes, but anyway, why would you change the position to fixed and remove the z-index.

This should be ok:

#myVideo {
    position: absolute;
    z-index: 4;
    right: 0;
    bottom: 0;
    top:0;
    right:0;
    width: 100%;
    height: 100%;
    background-image: url(imgs/flowers.jpg) no-repeat; 
    background-position: center center;
    background-size: contain;
    object-fit: cover; /*cover video background */
}
@ppsirius

This comment has been minimized.

Copy link
Author

ppsirius commented Oct 12, 2014

I have some problem with this z-index (dont show any text) so i change it.
There are two times "right" and I think that "left and top" is enought ;)

@alvarotrigo

This comment has been minimized.

Copy link
Owner

alvarotrigo commented Oct 12, 2014

You can probably leave it like this:

        #myVideo {
            position: absolute;
            right: 0;
            bottom: 0;
            top:0;
            width: 100%;
            height: 100%;
            background-image: url(imgs/flowers.jpg) no-repeat; 
            background-position: center center;
            background-size: contain;
            object-fit: cover; /*cover video background */
        }

I have some problem with this z-index (dont show any text) so i change it.

z-index might not be necessary, but of course, as it is absolute positioned the text on that section will have to be placed after the video element or be given a higher z-index.
That was probably your problem. You were maybe placing the text before the video element or with a lower z-index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.