Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded ability to specify direction to the 'setAllowScrolling' method. #48
Conversation
This comment has been minimized.
This comment has been minimized.
|
Set fixed. Confirmed working. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for it! |
This comment has been minimized.
This comment has been minimized.
|
Could you commit it again after updating your copy? I can not merge it anymore. |
This comment has been minimized.
This comment has been minimized.
sethsacher
commented
May 11, 2018
|
Where does this stand? This would be a handy feature for my site! |
This comment has been minimized.
This comment has been minimized.
|
@sethsacher it was never merged. I would encourage you to make use of fullPage.js instead, where this feature is implemented (and many others! ) I put much more time and effort on it and you can emulate the pagePiling.js behaviour by using the Parallax extension and using A related article about it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sparkison commentedApr 25, 2015
Updated code to take direction arguments for the setAllowScrolling method as in fullPage.js
Felt this was a missing, and a needed feature.