Skip to content

/ pagePiling.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for older mouse scrollwheels #117

Open
wants to merge 2 commits into
base: master
from
Open

Fix for older mouse scrollwheels #117

wants to merge 2 commits into from

Conversation

@ryanturner10
Copy link

ryanturner10 commented Nov 29, 2016

Changed delta operator to ‘less than or equal to’ for scrollwheels that
don’t change delta on small scrolls
Ryan Turner
Fix for older mouse scrollwheels
3badd91 
Changed delta operator to ‘less than or equal to’ for scrollwheels that
don’t change delta on small scrolls
@ryanturner10 ryanturner10 mentioned this pull request Nov 29, 2016
Open
@alvarotrigo

This comment has been minimized.

Sign in to view
Copy link
Owner

alvarotrigo commented Nov 29, 2016

An else should be enough.
But in any case, have you checked this solves your problem?
@alvarotrigo

This comment has been minimized.

Sign in to view
Copy link
Owner

alvarotrigo commented Nov 29, 2016 •
edited

fullPage.js uses:

                        if (delta < 0) {
                            scrolling('down', scrollable);

                        //scrolling up?
                        }else {
                            scrolling('up', scrollable);
                        }

And you probably don't have any issue there.
So not quite sure if the problem is there in any case.
Ryan Turner
Change to mimic fullPage.js
d89d4f7
@ryanturner10

This comment has been minimized.

Sign in to view
Copy link
Author

ryanturner10 commented Nov 29, 2016

Yes this solves the issue I was having. Pushed new commit to as suggested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ryanturner10 @alvarotrigo
You can’t perform that action at this time.